Hey @jogehl,

Thanks a lot for your contribution, I appreciate that! Could you please force-push your commit with a signoff? We require all of the commits to be signed, so currently the DCO check fails on your PR. You can find the instructions of how to do that here

Also I've just now realised you didn't provide an async version. Could you add it and the test for it as well? It will be mostly copy-paste

Also I've just now realised you didn't provide an async version. Could you add it and the test for it as well? It will be mostly copy-paste

where can I find the implementations for the async? I can't find the async version for the HashCommands.

Also I've just now realised you didn't provide an async version. Could you add it and the test for it as well? It will be mostly copy-paste

where can I find the implementations for the async? I can't find the async version for the HashCommands.

AFAICS AsyncHashCommands is just set to be the same as HashCommands. There is a subtle difference, though. valkey-py has a tricky class hierarchy that effectively makes HashCommands use synchronous version of execute_command whilst AsyncHashCommands is using the async one.

TL;DR: could you add an async test to verify it works? Thanks!

Codecov Report

❌ Patch coverage is 85.22727% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.29%. Comparing base (c291080) to head (2c05ea3).

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   76.28%   76.29%   +0.01%     
==========================================
  Files         129      129              
  Lines       33906    33994      +88     
==========================================
+ Hits        25864    25936      +72     
- Misses       8042     8058      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Is there anything else which is needed for this PR?

Hi @jogehl ! Looks good there's just one comment from @mkmkme that should be addressed before merging: #246 (comment) . Atm, the function would allow you to send something like the below to Valkey if you set more than one of (key + value, mapping, items).

127.0.0.1:6379> HSETEX myhash FIELDS 1 f4 v4 2 f5 v5 f6 v6
(error) ERR numfields should be greater than 0 and match the provided number of fields

This should be fixed now. Sorry for the delay.

merged, thanks again for the work @jogehl !